SNOW-3190420: Add start_nbctl.sh validation check for Notebook custom…#2815
Open
sfc-gh-jijiang wants to merge 6 commits intoajiang-SNOW_3202210-cre_validatefrom
Open
SNOW-3190420: Add start_nbctl.sh validation check for Notebook custom…#2815sfc-gh-jijiang wants to merge 6 commits intoajiang-SNOW_3202210-cre_validatefrom
sfc-gh-jijiang wants to merge 6 commits intoajiang-SNOW_3202210-cre_validatefrom
Conversation
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
3f91024 to
3e8901b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
SNOW-3190420: Add
start_nbctl.shvalidation check for Notebook custom imagesThis PR adds a Notebook-specific validation check to the
snow custom-image validateCLI command.For Notebook vNext, PEP injects
./start_nbctl.sh /shared/nbctlas the container entrypoint args. If this script is missing or not executable in the custom image, the container will crash immediately on startup. This check catches that before deployment.What changed:
image_validation.yaml: Addedrequired_scripts: [start_nbctl.sh]config entrymanager.py: Added_check_required_scriptshandler that runsdocker run ... test -x <script>to verify each script exists and is executabletest_manager.py: Added unit tests for pass (script present) and fail (script missing) scenarios, updated mock helper to supportmissing_scriptsparameterValidation:
python3 -m pytest tests/custom_images/ -v)start_nbctl.shexists and is executable in the officialsnowflake-notebook:ml-cpuimage