feat: [SNOW-3228385] upgrade python connector version#2817
Draft
sfc-gh-jwilkowski wants to merge 1 commit intomainfrom
Draft
feat: [SNOW-3228385] upgrade python connector version#2817sfc-gh-jwilkowski wants to merge 1 commit intomainfrom
sfc-gh-jwilkowski wants to merge 1 commit intomainfrom
Conversation
Comment on lines
+682
to
+683
| version = "4.3.0" | ||
| vcs = { type = "git", url = "https://github.com/snowflakedb/snowflake-connector-python", requested-revision = "jw/SNOW-3230072-fix-missed-file-permission-check-skipping", commit-id = "3064890abe9be2c4ad65c6cc75b283b03efdf369" } |
Contributor
There was a problem hiding this comment.
Version mismatch with VCS reference
The package declares version = "4.3.0" but uses a VCS reference to a feature branch (jw/SNOW-3230072-fix-missed-file-permission-check-skipping) instead of an actual 4.3.0 release tag. This creates several issues:
- Misleading version: If snowflake-connector-python 4.3.0 is not yet released or this branch is not actually version 4.3.0, dependency resolution will fail or behave unexpectedly
- No binary wheels: Unlike version 3.18.0 which had pre-built wheels for multiple platforms, this VCS reference has no wheels, forcing compilation from source on all platforms which will significantly slow installation and may fail on systems without build tools
- Release notes inconsistency: RELEASE-NOTES.md claims version 4.3.0 is being used, but the actual dependency is an unreleased branch
Fix: Either:
# Use actual released version with wheels
version = "4.3.0"
sdist = { url = "https://files.pythonhosted.org/packages/...", ... }
wheels = [...] # Include platform-specific wheelsOr if a pre-release is required:
# Use proper pre-release versioning
version = "4.3.0-dev+3064890"
vcs = { ... }Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
...