Skip to content

feat: [SNOW-3228385] upgrade python connector version#2817

Draft
sfc-gh-jwilkowski wants to merge 1 commit intomainfrom
jw/SNOW-3228385-upgrade-python-connector-again
Draft

feat: [SNOW-3228385] upgrade python connector version#2817
sfc-gh-jwilkowski wants to merge 1 commit intomainfrom
jw/SNOW-3228385-upgrade-python-connector-again

Conversation

@sfc-gh-jwilkowski
Copy link
Contributor

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.
  • I've described my changes in the documentation.

Changes description

...

Comment on lines +682 to +683
version = "4.3.0"
vcs = { type = "git", url = "https://github.com/snowflakedb/snowflake-connector-python", requested-revision = "jw/SNOW-3230072-fix-missed-file-permission-check-skipping", commit-id = "3064890abe9be2c4ad65c6cc75b283b03efdf369" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version mismatch with VCS reference

The package declares version = "4.3.0" but uses a VCS reference to a feature branch (jw/SNOW-3230072-fix-missed-file-permission-check-skipping) instead of an actual 4.3.0 release tag. This creates several issues:

  1. Misleading version: If snowflake-connector-python 4.3.0 is not yet released or this branch is not actually version 4.3.0, dependency resolution will fail or behave unexpectedly
  2. No binary wheels: Unlike version 3.18.0 which had pre-built wheels for multiple platforms, this VCS reference has no wheels, forcing compilation from source on all platforms which will significantly slow installation and may fail on systems without build tools
  3. Release notes inconsistency: RELEASE-NOTES.md claims version 4.3.0 is being used, but the actual dependency is an unreleased branch

Fix: Either:

# Use actual released version with wheels
version = "4.3.0"
sdist = { url = "https://files.pythonhosted.org/packages/...", ... }
wheels = [...]  # Include platform-specific wheels

Or if a pre-release is required:

# Use proper pre-release versioning
version = "4.3.0-dev+3064890"
vcs = { ... }

Spotted by Graphite

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant