SNOW-UD: Add inline UD test workflow and tox connector-swap support#4117
Open
sfc-gh-fpawlowski wants to merge 7 commits intomainfrom
Open
SNOW-UD: Add inline UD test workflow and tox connector-swap support#4117sfc-gh-fpawlowski wants to merge 7 commits intomainfrom
sfc-gh-fpawlowski wants to merge 7 commits intomainfrom
Conversation
sfc-gh-fpawlowski
force-pushed
the
ud-ci-workflow
branch
from
85594b2 to
178ab95
Compare
sfc-gh-fpawlowski
added
the
NO-CHANGELOG-UPDATES
| python-version: | ||
| description: 'Python version' | ||
| required: false | ||
| default: '3.10' |
Contributor
There was a problem hiding this comment.
is it only running one version at a time? should we consider default to the latest available python version in snowflake (3.13/3.14)?
Author
There was a problem hiding this comment.
Yes, for now we need it mostly to detect the API drift between both products. When we have solved all the missing contract elements, we can consider a full testing matrix.
And nice catch - changed to 3.13 : )
sfc-gh-fpawlowski
requested review from
sfc-gh-bkogan,
sfc-gh-helmeleegy,
sfc-gh-jrose,
sfc-gh-nkumar and
sfc-gh-yixie
- Add ud-inline-tests.yml (workflow_dispatch only) to run Snowpark tests against the universal-driver Python connector installed from git+https. - Add scripts/ud_tox_install_cmd.sh — wrapper that delegates to the standard tox_install_cmd.sh, then swaps snowflake-connector-python for the UD connector. Original install script is untouched. - Add [testenv:ud] and [testenv:ud-datasource] to tox.ini with their own install_command, passenv, and setenv. No changes to [testenv]. No behavior change for regular Snowpark CI — UD install logic is fully isolated in the new wrapper script and testenv sections. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
TODO: remove pull_request trigger once all tests are passing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Move the Universal Driver connector swap logic into the shared
tox_install_cmd.sh (conditional on ud_connector_path) so the UD
workflow runs the same tox environments as normal CI instead of
dedicated ud/ud-datasource envs.
- Add UD swap block to scripts/tox_install_cmd.sh (no-op when unset)
- Add ud_connector_path to [testenv] passenv
- Remove [testenv:ud] and [testenv:ud-datasource] from tox.ini
- Delete scripts/ud_tox_install_cmd.sh
- Workflow now invokes py${VER}-notdoctest-ci and datasource directly
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace the appended swap block with a proper 3-way conditional: ud_connector_path → snowflake_path → PyPI (in priority order). The appended approach ran the full PyPI install then the swap as a separate pass on every tox install_command invocation. The integrated approach mirrors the original design: UD takes explicit priority, snowflake_path is only used when UD is not set, and a single logical path runs per invocation. Also removes the decorative comment banners added by the previous edit, which were inconsistent with the surrounding code style. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add 'Run doctest' step using py${PYTHON_VERSION}-doctest-notudf-ci,
matching the pattern from daily_precommit.yml.
- Change default python-version input from 3.10 to 3.13 (latest
Snowflake-supported Python).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sfc-gh-fpawlowski
force-pushed
the
ud-ci-workflow
branch
from
cb7b143 to
44cf53e
Compare
sfc-gh-aling
approved these changes
Mar 13, 2026
Comment on lines
+77
to
+78
| curl https://packages.microsoft.com/keys/microsoft.asc | sudo apt-key add - | ||
| curl https://packages.microsoft.com/config/ubuntu/$(lsb_release -rs)/prod.list \ |
Contributor
There was a problem hiding this comment.
Is there a safer way to install these than curling from an external URL?
sfc-gh-joshi
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No behavior change for regular Snowpark CI (ud_connector_path unset falls through to existing snowflake_path / PyPI logic).
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-NNNNNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.