SNOW-3240486: Improve rowcount testing#561
Open
sfc-gh-jszczerbinski wants to merge 2 commits intomainfrom
Open
SNOW-3240486: Improve rowcount testing#561sfc-gh-jszczerbinski wants to merge 2 commits intomainfrom
sfc-gh-jszczerbinski wants to merge 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands ODBC SQLRowCount end-to-end coverage by adding new scenarios for null RowCountPtr handling and additional DML patterns (MERGE with DELETE, UPDATE with JOIN, INSERT from multi-table JOIN), and documents the resulting old-vs-new driver behavior difference.
Changes:
- Added new Gherkin scenarios covering null
RowCountPtr(HY009) and additional DML row-count cases. - Implemented corresponding Catch2 e2e tests in
odbc_testsfor each new scenario. - Documented Behavior Difference BD#26 for the null
RowCountPtrreturn-code/SQLSTATE discrepancy.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/definitions/odbc/query/sql_row_count.feature |
Adds new SQLRowCount scenarios (HY009 null pointer + additional DML row count cases). |
odbc_tests/tests/e2e/query/sql_row_count.cpp |
Adds Catch2 e2e tests implementing the new scenarios, including old/new driver branching for BD#26. |
odbc_tests/BehaviorDifferences.yaml |
Adds BD#26 documentation for null RowCountPtr behavior change. |
You can also share your feedback on Copilot code review. Take the survey.
sfc-gh-jszczerbinski
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.