Fixed a special character issue on Windows. - #11
Merged
Conversation
Change(s):
[1] This commit fixed an issue that the output filename can't be
correctly determined on Windows when the title of an audiobook
contains any special character.
For example, the title '君を守ろうとする猫の話: (小学館)' can't be
correctly handled due to the fact that it contains ':'
character.
To solve this problem, the changes in this commit will replace
all special characters with underline character ('_').
Contributor(s):
[1] Ji WenCong <xiaojsoft@gmail.com>
Owner
|
Thanks for the PR! And I hope this package serves you well! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change(s):
[1] This commit fixed an issue that the output filename can't be
correctly determined on Windows when the title of an audiobook
contains any special character.
Contributor(s):
[1] Ji WenCong xiaojsoft@gmail.com