Skip to content

Remove header "Server" issue #338#341

Merged
jezen merged 1 commit into
snoyberg:masterfrom
ktak-007:remove-server-header-issue-338
May 27, 2026
Merged

Remove header "Server" issue #338#341
jezen merged 1 commit into
snoyberg:masterfrom
ktak-007:remove-server-header-issue-338

Conversation

@ktak-007

Copy link
Copy Markdown
Contributor

No description provided.

@ulidtko ulidtko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a fix of #338, LOTM

@jezen jezen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is right. Thanks!

@jezen jezen merged commit a8931b8 into snoyberg:master May 27, 2026
9 checks passed
@jappeace

Copy link
Copy Markdown
Collaborator

please update the changelog too

@ktak-007

Copy link
Copy Markdown
Contributor Author

@jappeace, I can add to the changelog the text:

## 2.3.4

- HTTP responses no longer contain the Server header. [338](https://github.com/snoyberg/keter/issues/338)

But I don't know should I bump version (in keter.cabal too) or should I just add this text into the 2.3.3 section?

@jappeace

Copy link
Copy Markdown
Collaborator

@ktak-007 yes should be 2.4.0 I guess, this is breaking according to the pvp, and 2.3.3 has been released ages ago, you need to update to the latest master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants