Fix misleading usage message and silent dir creation for bad config path#343
Merged
Merged
Conversation
Keter treated a nonexistent config path as the home directory and silently populated a tree there. It now errors on a path that is neither an existing file nor directory, and the usage message describes both accepted forms. Closes snoyberg#199
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #199.
Running
keter <path>with a path intended as a config file that doesn't exist silently treated that path as the keter home directory and populated a subdirectory tree inside it — leaving users hunting for their logs and config. The usage message added to the confusion by calling the argument<config file>when keter expects the home directory (or a config file).This distinguishes three cases explicitly in
runKeterConfigReader: an existing file is decoded as config, an existing directory is used askconfigDir, and a path that is neither now throws a newConfigPathDoesNotExistexception instead of being silently adopted. The usage string is updated to describe both accepted forms.Bumps to 2.4.1 with a changelog entry.