[codex] Map AI failure spans to error taxonomy#525
Merged
Conversation
5d87657 to
13ba130
Compare
13ba130 to
212e828
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
guardrail_blocked,rate_limited,content_filter,budget_exceeded,upstream_5xx, andtimeout.error.typeon the actualai.requestspan for rate limits, guardrails, budget preflight failures, provider status failures, streaming read failures, and all-provider transport failures.docs/llms-full.txtwith the taxonomy.Root cause
Some AI failure paths recorded on
tracing::Span::current()even though theai.requestspan was not entered, and provider response failures were not consistently classified for span status/error attributes.Validation
cargo test -p sbproxy-core ai_error_classification_tests --lockedcargo test -p sbproxy-ai record_error_marks_span_failed --lockedcargo test -p sbproxy-ai error_type_constants_cover_ai_failure_taxonomy --lockedcargo test -p sbproxy-core --lockedcargo test -p sbproxy-ai --lockedcargo fmt --all --checkgit diff --check./scripts/regen-llms-full.sh --checkcargo test -p sbproxy-e2e --test otlp_span_arrival_e2e --lockedcargo test -p sbproxy-e2e --test otlp_span_arrival_http_e2e --lockedNo new libraries were added; NOTICE did not need changes.
Linear: WOR-1215