Closed
Conversation
arpan404
requested changes
Feb 13, 2025
Member
arpan404
left a comment
arpan404
left a comment
There was a problem hiding this comment.
Make it export from main file
arpan404
added
proposal
arpan404
reviewed
Feb 13, 2025
Member
arpan404
left a comment
arpan404
left a comment
There was a problem hiding this comment.
Also add jsdocs on each method like alphanumeric
arpan404
requested changes
Feb 13, 2025
Member
arpan404
left a comment
arpan404
left a comment
There was a problem hiding this comment.
Add validation to length, use Number.isInteger to know if the value is integer
Also make the otp length max to be of length 30 and minimum of 4, if the validation fails, use logger.warn from joorLogger and use default values length: 8
Add validation to custom one: for eg, if length of charSet must minimum 10, also validate if the charSet is string
pratikacharya1234
force-pushed
the
branch-otp-generator
branch
from
f61e3fd to
ad07f58
Compare
pratikacharya1234
force-pushed
the
branch-otp-generator
branch
from
99ebea3 to
9aa601c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.