Potential fix for 1 code quality finding

[sanjomo]

This PR applies 1/1 suggestions from code quality AI findings.

Summary by CodeRabbit

• Bug Fixes
  • Improved error messages for JSONP packet decoding failures with enhanced diagnostic details.

[coderabbitai]

Warning

Rate limit exceeded

@sanjomo has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 37 minutes and 43 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 189029e7-2a29-44ef-81f9-3208718dde32

📥 Commits

Reviewing files that changed from the base of the PR and between 857de7a and 323a845.

📒 Files selected for processing (1)

• netty-socketio-core/src/main/java/com/socketio4j/socketio/protocol/PacketDecoder.java

📝 Walkthrough

Walkthrough

PacketDecoder.preprocessJson enhances JSONP handling to throw an IllegalArgumentException that includes the first two observed bytes in hexadecimal format when the expected "d=" prefix is missing, improving diagnostic information for invalid JSONP payloads.

Changes

JSONP error diagnostics

Layer / File(s)	Summary
JSONP validation error message enhancement netty-socketio-core/src/main/java/com/socketio4j/socketio/protocol/PacketDecoder.java	The JSONP prefix validation failure now throws an IllegalArgumentException containing the hex-formatted first two bytes read from the input, replacing a generic error message for better diagnostic context.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A socket dreams in JSON streams,
When d= is lost, all is not lost—
Two bytes in hex shine crystal clear,
Debugging whispers, errors sincere. 🐰✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is incomplete and lacks most required sections from the template, including type of change, detailed changes made, testing information, and checklist items.	Expand the description to include the required sections: specify the type of change, list detailed changes made, document testing performed, and complete the checklist items.
Title check	❓ Inconclusive	The title "Potential fix for 1 code quality finding" is vague and generic, using non-descriptive terms that don't convey meaningful information about the specific change made to the codebase.	Replace with a more specific title that describes the actual change, such as "Improve error message clarity in JSONP packet decoder" or "Add hex-formatted bytes to JSONP parsing error message".

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ai-findings-autofix/netty-socketio-core-src-main-java-com-socketio4j-socketio-protocol-PacketDecoder.java

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@netty-socketio-core/src/main/java/com/socketio4j/socketio/protocol/PacketDecoder.java`:
- Line 80: The hex formatting in the IllegalArgumentException message uses
content.getByte(ri) and content.getByte(ri + 1) which can produce sign-extended
values for bytes >= 0x80; update the formatting to mask each byte with & 0xFF
(or call getUnsignedByte) before passing to String.format so the message shows
correct 0x00–0xFF hex values (refer to the throw site in PacketDecoder.java
where the exception is created).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6cfe420e-3ef4-40f3-ae19-48b105443ff5

📥 Commits

Reviewing files that changed from the base of the PR and between 09941f1 and 857de7a.

📒 Files selected for processing (1)

• netty-socketio-core/src/main/java/com/socketio4j/socketio/protocol/PacketDecoder.java