Fix KeyError in config_flow and update aioaquarea version pin#444
Open
tazz-apps wants to merge 2 commits intosockless-coding:masterfrom
Open
Fix KeyError in config_flow and update aioaquarea version pin#444tazz-apps wants to merge 2 commits intosockless-coding:masterfrom
tazz-apps wants to merge 2 commits intosockless-coding:masterfrom
Conversation
config_flow.py line 49: `entry.data[KEY_DOMAIN]` raises KeyError
when iterating existing config entries that don't have the "domain"
key. Changed to `entry.data.get(KEY_DOMAIN)` — returns None if
missing, comparison evaluates to False, loop continues safely.
`aioaquarea==0.7.2` is an exact pin that conflicts
with home-assistant-aquarea which requires `>=1.0.6`. When both
integrations are installed, the resolver picks 0.7.2 and both fail.
Additionally, 0.7.2 is broken against the current Panasonic API
(`NoneType` error in `__login_production`). Loosened to `>=1.0.6`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
config_flow.py line 49:
entry.data[KEY_DOMAIN]raises KeyErrorwhen iterating existing config entries that don't have the "domain"
key. Changed to
entry.data.get(KEY_DOMAIN)— returns None ifmissing, comparison evaluates to False, loop continues safely.
manifest.json:
aioaquarea==0.7.2is an exact pin that conflictswith home-assistant-aquarea which requires
>=1.0.6. When bothintegrations are installed, the resolver picks 0.7.2 and both fail.
Additionally, 0.7.2 is broken against the current Panasonic API
(
NoneTypeerror in__login_production). Loosened to>=1.0.6Tested on HA 2026.3.0 with both integrations installed simultaneously.