Skip to content

ImportPlugin now takes a pointer to the globals #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jnbrunet merged 2 commits into from
Jun 14, 2020
Merged

ImportPlugin now takes a pointer to the globals #10

jnbrunet merged 2 commits into from
Jun 14, 2020

Conversation

@marques-bruno
Copy link
Member

@marques-bruno marques-bruno commented Jun 12, 2020 •
edited
Loading

This way we can use default py::globals() if necessary without having to instantiate globals before calling the method

@marques-bruno marques-bruno self-assigned this Jun 12, 2020
jnbrunet
jnbrunet approved these changes Jun 14, 2020
View reviewed changes
Copy link
Contributor

@jnbrunet jnbrunet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me

@jnbrunet jnbrunet merged commit 1808faf into sofa-framework:master Jun 14, 2020
@guparan guparan added this to the v20.12 milestone Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jnbrunet jnbrunet jnbrunet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@marques-bruno marques-bruno

Labels

pr: clean-fix pr: fast-merge pr: status ready

Projects

None yet

Milestone

v20.12

Development

Successfully merging this pull request may close these issues.

4 participants

@marques-bruno @jnbrunet @guparan @hugtalbot