Install tests and remove empty input module #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can always bring it back once we have at least one implementation of input events propagated to this module.
marques-bruno
approved these changes
Jun 14, 2020
Member
marques-bruno
left a comment
marques-bruno
left a comment
There was a problem hiding this comment.
Thanks @jnbrunet
The EXPORT BindingsTargets copies the test binaries in the same folder as the binding libs is that it?
Contributor
Author
|
Hey @marques-bruno However, I forgot that the binary isn't the only thing needed for SP3 tests, I need to install the test scripts too :-P I will put this PR in WIP and keep update it until I can make the CI actions pass. |
The PythonEnvironment::getPythonCallingPointAsFileInfo method hasn't been updated with SofaRuntime.getPythonCallingPoint, and since the later had changed its return type, the method was failing.
Contributor
Author
|
All right, all tests on Ubuntu CI pass with this branch, ready to be reviewed again @marques-bruno :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good news, I'm getting closer to have an action-based CI working. To isolate the build CI from the test CI, I need to get a clean installation of both SOFA and SP3. This will also make sure that we are able to run SP3 from an installed package.