[Bindings.Sofa.Helper] Add MessageHandler context manager class #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marques-bruno
added
pr: status to review
pr: status wip
and removed
pr: status wip
pr: status to review
labels
bindings/Sofa/src/SofaPython3/Sofa/Helper/Binding_MessageHandler.cpp
Outdated
Show resolved
Hide resolved
bindings/Sofa/src/SofaPython3/Sofa/Simulation/Submodule_Simulation.cpp
Outdated
Show resolved
Hide resolved
|
|
||
| m.def("init", []() { | ||
| MessageDispatcher::clearHandlers(); | ||
| MessageDispatcher::addHandler(&MainConsoleMessageHandler::getInstance()); |
Contributor
There was a problem hiding this comment.
Il n'y a pas de singletont pour ConsoleMessageHandler.
Member
Author
There was a problem hiding this comment.
Désolé oublié de référence la PR SOFA associée : sofa-framework/sofa#1434
6 tasks
Contributor
|
Ok for me, and tests have passed 👍 |
ScheiklP
added a commit
to ScheiklP/SofaPython3
that referenced
this pull request
Dec 13, 2021
…-framework#18) * WIP: Add MessageHandler context manager class * ADD ConsoleMessageHandler at simu init * Working MessageHandler with context * Placing MessageHandlers (Console and PerComponent) in SofaRuntime.init() * Cleanup * Update CMakeLists.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lets you write MessageHandlers in Python.
It also lets you instantiate them in a RAII way by taking advantage of Python3's context managers.
All you have to do is implement the process function in a MessageHandler-inherited python class (see diff in Message.py)
@damienmarchal @jnbrunet