[SofaPython3] Restore the plugins automatic loading of python libraries. #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damienmarchal
force-pushed
the
addAutomaticRegisteringOfPythonLib
branch
from
0e1269d to
fa131e9
Compare
…thon libraries. When we load a c++ plugin it may be packaged with additional python files (examples, libraries, or per plugin binding). These files should be visible from the python environment. This is done by the added code that scans the plugin's directory and register any path matching the following patterns: pluginName/lib/site-packages pluginName/lib/python3/site-packages This behavior was the implemented in the previous version of SofaPython and proved to be useful.
damienmarchal
force-pushed
the
addAutomaticRegisteringOfPythonLib
branch
from
fa131e9 to
cb07dac
Compare
Contributor
|
I'm not a fan of automatically adding things to my sys.path, and I'm a little bit surprise it is coming from you ;), but at least there is an info message in SP3 when things get added to sys.path . Looks like this will only work for plugins loaded before SofaPython3, and SofaPython3 itself. Ok with me if you want to merge it. |
Contributor
Author
|
You are saying the feature only work for plugin loaded before SofaPython3 and SofaPython3 itself. PythonEnvironment::addPythonModulePathsForPluginsByName("MyPluginName") so only its own python modules are registered. The general idea is that we don't want to force per-system/per-user installation/manual setting of sys*path of the python modules that are connected to a loaded plugin. |
hugtalbot
pushed a commit
to hugtalbot/SofaPython3
that referenced
this pull request
Feb 6, 2023
Add ReadTheDocSupport 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we load a c++ plugin it may be packaged with additional python files
(examples, libraries, or per plugin binding). These files should be visible from the python environment.
This is done by the added code that scans the plugin's directory and register any path matching the following patterns:
pluginName/lib/site-packages
pluginName/lib/python3/site-packages
This behavior was the implemented in the previous version of SofaPython and proved to be useful.