Skip to content

FIX: missing debug postfix in SofaPython3 plugin #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marques-bruno merged 2 commits into from
Aug 5, 2020
Merged

FIX: missing debug postfix in SofaPython3 plugin #37

marques-bruno merged 2 commits into from
Aug 5, 2020

Conversation

@marques-bruno
Copy link
Member

@marques-bruno marques-bruno commented Aug 3, 2020

No description provided.

@marques-bruno marques-bruno self-assigned this Aug 3, 2020
@jnbrunet
Copy link
Contributor

jnbrunet commented Aug 4, 2020

Looks like the build is failing. Does not seems to be related to your PR, do you know what's going on?

Plugin/src/SofaPython3/Prefab.cpp:61:65: error: no match for ‘operator=’ (operand types are ‘DeprecatedAndRemoved’ and ‘sofa::core::objectmodel::ComponentState’)
     m_componentstate = sofa::core::objectmodel::ComponentState::Valid;
                                                                 ^~~~~
In file included from /opt/sofa/include/SofaFramework/sofa/core/objectmodel/BaseContext.h:25:0,
                 from /opt/sofa/include/SofaFramework/sofa/core/objectmodel/BaseObject.h:25,
                 from /opt/sofa/include/SofaFramework/sofa/core/objectmodel/Context.h:25,
                 from /opt/sofa/include/SofaFramework/sofa/simulation/Node.h:28,
                 from /opt/sofa/include/SofaSimulation/SofaSimulationGraph/DAGNode.h:26,
                 from Plugin/src/SofaPython3/Prefab.h:2,
                 from Plugin/src/SofaPython3/Prefab.cpp:1:
/opt/sofa/include/SofaFramework/sofa/core/objectmodel/Base.h:102:7: note: candidate: constexpr DeprecatedAndRemoved& DeprecatedAndRemoved::operator=(const DeprecatedAndRemoved&)
 class DeprecatedAndRemoved {};
       ^~~~~~~~~~~~~~~~~~~~
/opt/sofa/include/SofaFramework/sofa/core/objectmodel/Base.h:102:7: note:   no known conversion for argument 1 from ‘sofa::core::objectmodel::ComponentState’ to ‘const DeprecatedAndRemoved&’
/opt/sofa/include/SofaFramework/sofa/core/objectmodel/Base.h:102:7: note: candidate: constexpr DeprecatedAndRemoved& DeprecatedAndRemoved::operator=(DeprecatedAndRemoved&&)
/opt/sofa/include/SofaFramework/sofa/core/objectmodel/Base.h:102:7: note:   no known conversion for argument 1 from ‘sofa::core::objectmodel::ComponentState’ to ‘DeprecatedAndRemoved&&’

@marques-bruno
Copy link
Member Author

marques-bruno commented Aug 4, 2020

Looks like the build is failing. Does not seems to be related to your PR, do you know what's going on?

Plugin/src/SofaPython3/Prefab.cpp:61:65: error: no match for ‘operator=’ (operand types are ‘DeprecatedAndRemoved’ and ‘sofa::core::objectmodel::ComponentState’)
     m_componentstate = sofa::core::objectmodel::ComponentState::Valid;
                                                                 ^~~~~
In file included from /opt/sofa/include/SofaFramework/sofa/core/objectmodel/BaseContext.h:25:0,
                 from /opt/sofa/include/SofaFramework/sofa/core/objectmodel/BaseObject.h:25,
                 from /opt/sofa/include/SofaFramework/sofa/core/objectmodel/Context.h:25,
                 from /opt/sofa/include/SofaFramework/sofa/simulation/Node.h:28,
                 from /opt/sofa/include/SofaSimulation/SofaSimulationGraph/DAGNode.h:26,
                 from Plugin/src/SofaPython3/Prefab.h:2,
                 from Plugin/src/SofaPython3/Prefab.cpp:1:
/opt/sofa/include/SofaFramework/sofa/core/objectmodel/Base.h:102:7: note: candidate: constexpr DeprecatedAndRemoved& DeprecatedAndRemoved::operator=(const DeprecatedAndRemoved&)
 class DeprecatedAndRemoved {};
       ^~~~~~~~~~~~~~~~~~~~
/opt/sofa/include/SofaFramework/sofa/core/objectmodel/Base.h:102:7: note:   no known conversion for argument 1 from ‘sofa::core::objectmodel::ComponentState’ to ‘const DeprecatedAndRemoved&’
/opt/sofa/include/SofaFramework/sofa/core/objectmodel/Base.h:102:7: note: candidate: constexpr DeprecatedAndRemoved& DeprecatedAndRemoved::operator=(DeprecatedAndRemoved&&)
/opt/sofa/include/SofaFramework/sofa/core/objectmodel/Base.h:102:7: note:   no known conversion for argument 1 from ‘sofa::core::objectmodel::ComponentState’ to ‘DeprecatedAndRemoved&&’

Yes, I know, I'll fix it ASAP ;)

@marques-bruno
Copy link
Member Author

marques-bruno commented Aug 4, 2020

@jnbrunet #38

@jnbrunet
Copy link
Contributor

jnbrunet commented Aug 4, 2020

You will have to rebase your branch to sp3/master to get your #38 fix for the CI

@marques-bruno
Copy link
Member Author

marques-bruno commented Aug 4, 2020

You will have to rebase your branch to sp3/master to get your #38 fix for the CI

oh I thought master was automatically rebased on PRs

@jnbrunet
Copy link
Contributor

jnbrunet commented Aug 4, 2020

You will have to rebase your branch to sp3/master to get your #38 fix for the CI

oh I thought master was automatically rebased on PRs

This should in theory be a one line changes to the github workflow file ^^

@marques-bruno marques-bruno merged commit 83ee817 into master Aug 5, 2020
@marques-bruno marques-bruno deleted the fix_debug_build branch September 10, 2020 13:41
@guparan guparan added this to the v20.12 milestone Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnbrunet jnbrunet Awaiting requested review from jnbrunet

@damienmarchal damienmarchal Awaiting requested review from damienmarchal

Assignees

@marques-bruno marques-bruno

Labels

pr: fast-merge pr: status ready

Projects

None yet

Milestone

v20.12

Development

Successfully merging this pull request may close these issues.

4 participants

@marques-bruno @jnbrunet @guparan