[Lagrangian] Add stopping condition in NNCG #5667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…info in GenericCosntraintSolver data that are dependent on the method type. Need to find a way of setting the solving method by adding a component in the scene.
…ritance. Now the constraintProblem is only a container
…oposed in the original paper
bakpaul
added
pr: fix
Contributor
|
[ci-build][with-all-tests] |
fredroy
approved these changes
Oct 23, 2025
alxbilger
previously requested changes
Oct 23, 2025
Sofa/Component/AnimationLoop/src/sofa/component/animationloop/FreeMotionAnimationLoop.cpp
Outdated
Show resolved
Hide resolved
...int/Lagrangian/Solver/src/sofa/component/constraint/lagrangian/solver/ConstraintSolverImpl.h
Outdated
Show resolved
Hide resolved
th-skam
approved these changes
Oct 23, 2025
Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com>
fredroy
added
pr: status ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #5666
This adds a stopping condition based on the force evolution rate as proposed in the original paper.
Relevant commit : 200e4d8
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if