Add builder_from_env to use custom env var#13
Open
DaveWK wants to merge 2 commits into
Open
Conversation
This adds a wrapper to Builder::from_env so a variable other than RUST_LOG can be used This also updates the log crate to the latest, where the feature has been changed to "kv_unstable_std", as well as updates env_logger to 0.9
…mutex to avoid format changes impacting other tests
Author
|
I have added some helpers to the tests to allow the logger to be replaced by a new instance. This also required making 2 of the tests run serially to avoid changing the filters/formatters that another test depended on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a wrapper to Builder::from_env so a variable other than
RUST_LOG can be used
This also updates the log crate to the latest, where the feature has
been changed to "kv_unstable_std", as well as updates env_logger to 0.9
I added a WriteAdapter struct into the tests to capture log output into variables for testing