Change configuration in LLMModule so it can be set before loading model #734
+28
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, there is no other way to set configuration in
useLLMother than load model first, and then callconfiguremethod. This PR make it possible to configure parameters before loading the actual model.Introduces a breaking change?
Type of change
Tested on
Testing instructions
Try to run configure on hook returned by
useLLMand check that everything works.For simplicity, I present the example way how to test it inside our library:
apps/llm/app/my_test/index.tsx:apps/llm/app/_layout.txs:apps/llm/app/index.tsx:Run llm app and ask about anything. Generation config should work correctly, and now responses of the LLM should be super ecstatic. Now, move this part:
before loading the model and check if everything works correct.
Screenshots
Related issues
Checklist
Additional notes