Add changedSinceSlot on account fetch operations#392
Open
cloakd wants to merge 5 commits intosolana-foundation:mainfrom
Open
Add changedSinceSlot on account fetch operations#392cloakd wants to merge 5 commits intosolana-foundation:mainfrom
changedSinceSlot on account fetch operations#392cloakd wants to merge 5 commits intosolana-foundation:mainfrom
Conversation
cloakd
changed the title
changedSinceSlot on account fetch operations
Contributor
Author
|
Updated to keep up with changes on base branch. |
Contributor
sonicfromnewyoke
left a comment
sonicfromnewyoke
left a comment
There was a problem hiding this comment.
I really like this improvement, becase there are devs who use comercial RPCs.
the only what i'd like to ask you - adding some extra description on who supports those (like FluxRPC) fields
| Filters []RPCFilter `json:"filters,omitempty"` | ||
|
|
||
| // Return only the accounts that have changed since this slot | ||
| ChangedSinceSlot *uint64 `json:"changedSinceSlot,omitempty"` |
Contributor
There was a problem hiding this comment.
the same description should be here, i believe
Co-authored-by: Sonic <sonic.from.new.yoke@gmail.com>
Contributor
Author
|
Sure, typically we dont over document when the field is self-explanatory but if its code guidelines happy to update |
Contributor
Author
|
@sonicfromnewyoke should be good to go now! |
Contributor
commit-lint (used for the changelog) and golangci-lint (used for the code quality) are failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FluxRPC & Helius both offer
changedSinceSlotarg for account fetch calls - this significantly reduces the gPA data loads needed for keeping 3rd party services in sync as incremental sync can be done rather than fetching full account state data.Especially useful for large programs such as PumpFun (most RPCs disallow a full gPA on this program now)