Fix double render error in StoreController#445
Merged
jarednorman merged 1 commit intoJun 8, 2026
Conversation
We don't need to render when using `fresh_when`, as it will either render the partial or return a not modified status code. Co-authored-by: Adam Mueller <adam@super.gd> Co-authored-by: Alistair Norman <alistair@super.gd> Co-authored-by: Jared Norman <jared@super.gd> Co-authored-by: Noah Silvera <noah@super.gd> Co-authored-by: Senem Soy <senem@super.gd> Co-authored-by: Sofia Besenski <sofia@super.gd>
forkata
marked this pull request as ready for review
June 3, 2026 23:02
adammathys
approved these changes
Jun 3, 2026
jarednorman
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It seems like the way this method works changed in Rails 8 and we no longer
need to render when using
fresh_when, as it will either render the partial orreturn a not modified status code. The previous behaviour would result in a double
render error on new versions of Rails.
Fixes #444
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: