Skip to content

fix(compile): error handling, unlimited turns, and non-zero exit code #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
someaka wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(compile): error handling, unlimited turns, and non-zero exit code #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 28 additions & 8 deletions scripts/compile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,15 @@
CONCEPTS_DIR = KNOWLEDGE_DIR / "concepts"
CONNECTIONS_DIR = KNOWLEDGE_DIR / "connections"


class CompilationError(Exception):
"""A compilation that could not complete."""

def __init__(self, log_name: str, detail: str) -> None:
super().__init__(f"{log_name}: {detail}")
self.log_name = log_name
self.detail = detail

# OpenAI-compatible tool definitions for the compiler
TOOLS = [
{
Expand Down Expand Up @@ -295,7 +304,9 @@ def compile_daily_log(log_path: Path, state: dict) -> None:
]

max_turns = int(cfg("compiler.max_turns", 30))
for turn in range(1, max_turns + 1):
turn = 0
while max_turns == 0 or turn < max_turns:
turn += 1
try:
resp = ollama_completion(
messages=messages,
Expand All @@ -304,13 +315,11 @@ def compile_daily_log(log_path: Path, state: dict) -> None:
max_tokens=int(cfg("compiler.max_tokens", 4096)),
)
except RuntimeError as e:
print(f" API error: {e}")
return
raise CompilationError(log_path.name, f"API error: {e}") from e

choices = resp.get("choices")
if not choices:
print(" API error: Ollama returned empty choices")
return
raise CompilationError(log_path.name, "Ollama returned empty choices")
choice = choices[0]
message = choice.get("message") or {}
content = message.get("content") or ""
Expand All @@ -336,8 +345,7 @@ def compile_daily_log(log_path: Path, state: dict) -> None:
"content": result,
})
else:
print(f" Warning: reached max_turns ({max_turns})")
return
raise CompilationError(log_path.name, f"reached max_turns ({max_turns})")

# Update state
rel_path = f"daily/{log_path.name}"
Expand Down Expand Up @@ -397,9 +405,15 @@ def main():
if args.dry_run:
return

failed = []
for i, log_path in enumerate(to_compile, 1):
print(f"\n[{i}/{len(to_compile)}] Compiling {log_path.name}...")
compile_daily_log(log_path, state)
try:
compile_daily_log(log_path, state)
except CompilationError as e:
print(f" ERROR: {e.detail}")
failed.append(log_path.name)
continue

if f"daily/{log_path.name}" not in state.get("ingested", {}):
print(f" Warning: compilation did not complete for {log_path.name}; skipping archive.")
Expand All @@ -418,6 +432,12 @@ def main():
articles = list(list_wiki_articles())
print(f"\nCompilation complete.")
print(f"Knowledge base: {len(articles)} articles")

if failed:
print(f"\nFAILURES ({len(failed)}):")
for name in failed:
print(f" - {name}")
sys.exit(3)
finally:
release_lock(KNOWLEDGE_DIR)

Expand Down