JA2 Final - #3
Open
somewatson wants to merge 2 commits into
Open
Conversation
- Review lessons - See if there's common vocabulary categories we can use - Come up with a list that encapsulates all the lessons
- Include Ch 6 in the index - Fix bug where it only showed the cards if the number of cards was a multiple of 3 - Now it can handle any number of cards, and if it's not a multiple of 3, it will skip the card - Split "pronunciation" into Japanese pronunciation and English pronunciation - This allows us to provide hiragana/katakana and romaji in the date structure - Add enum for vocab categories (including nouns, ru-verbs, u-verbs, etc.) - Show vocab category as a little tag on the card
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review lessons