Dial-out telemetry wildcard subscription support - #729
Open
Verma-Anukul wants to merge 3 commits into
Open
Verma-Anukul wants to merge 3 commits into
Verma-Anukul wants to merge 3 commits into
Conversation
Contributor
|
/azp run |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Verma-Anukul
changed the title
Contributor
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Verma-Anukul
changed the title
Contributor
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Contributor
|
Hi, there are workflow run(s) waiting for approval, you may be first-time contributor. I will notify maintainers to help approve once PR is approved. Thanks! ---Powered by SONiC BuildBot
|
Contributor
Author
|
@hdwhdw |
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 729 in repo sonic-net/sonic-gnmi |
Verma-Anukul
added a commit
to Verma-Anukul/sonic-gnmi
that referenced
this pull request
Aug 4, 2026
No functional change; retrigger Azure Pipelines for PR sonic-net#729. Signed-off-by: Verma-Anukul <anukulverma2013@gmail.com>
Contributor
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
hdwhdw
self-requested a review
August 4, 2026 15:21
hdwhdw
requested changes
Aug 4, 2026
hdwhdw
left a comment
hdwhdw
left a comment
Contributor
There was a problem hiding this comment.
This looks like at least 3 features to me. Can you split them?
Route dialout subscriptions via IsTargetDb() so DB and OC_YANG targets are selected dynamically. Propagate subscribe send failures through FailedSend()/SentOne() for proper client lifecycle handling. Signed-off-by: Verma-Anukul <anukulverma2013@gmail.com>
Reorder third-party imports so gofmt passes in CI. Signed-off-by: Verma-Anukul <anukulverma2013@gmail.com>
Verma-Anukul
force-pushed
the
upstream/35281-wildcard-dialout
branch
from
August 4, 2026 15:28
594c76a to
e82d361
Compare
Contributor
|
/azp run |
This was referenced Aug 4, 2026
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Contributor
Author
Verma-Anukul
changed the title
Reset in-memory telemetry client state between TestGNMIDialOutPublish subtests so the pipe-separated CONFIG_DB key case is not broken by stale subscriptions from the underscore-key case. Also add report_interval to the YANG-canonical subtest for parity with the stream-mode wildcard case. Signed-off-by: Verma-Anukul <anukulverma2013@gmail.com>
Contributor
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Contributor
Author
|
@hdwhdw |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split per review — this PR is dialout wildcard only now.
Other changes from the original branch:
normalizeOrigin→ Subscribe support for openconfig-* module origins #735Changes
IsTargetDb()for dynamic DB/OC_YANG target selectionFailedSend()/SentOne()Test plan
/azp rungo test ./dialout/dialout_client/... -count=1