Conversation
Signed-off-by: Dawei Huang <daweihuang@microsoft.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the build and install logic in the top-level Makefile to define a single “product binaries” manifest and to standardize both native and cross builds to emit the same set of artifacts into build/bin, aligning packaging/install staging with that manifest.
Changes:
- Switches build steps to consistently use
go build -o $(BUILD_DIR)/...(instead of mixinggo buildvsgo install) and ensures$(BUILD_DIR)exists. - Introduces
PRODUCT_BINARIESas a manifest of shipped executables and uses it to drivemake installstaging into/usr/sbin. - Updates gNMI client build outputs to also land in
build/binfor both native and cross builds.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Dawei Huang <daweihuang@microsoft.com>
Contributor
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Contributor
Author
|
Azure build
No downstream failure affected the sonic-gnmi package, image, or executed KVM paths. The sonic-buildimage PR remains a draft. Do not merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makefiledefines one manifest for the nine sonic-gnmi product binaries.build/bin.make deinstalluse this manifest.Scope
This PR changes only
Makefile. It does not change test fixtures, test privilege use, or cleanup behavior.Verification
CROSS_BUILD_ENVIRON=yproduced the same nine binaries.make installstaged all nine declared binaries in/usr/sbin.git diff --checkpassed.Azure DevOps task: 39500132