Require authentication for remote gNOI KillProcess calls - #776
Draft
ashutosh-agrawal wants to merge 1 commit into
Draft
ashutosh-agrawal wants to merge 1 commit into
ashutosh-agrawal wants to merge 1 commit into
Conversation
Signed-off-by: Ashutosh Agrawal <ashu@cisco.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
KillProcesschanges host service state, but the handler currently continues when the telemetry server has no client authentication configured. A remote TCP client can therefore stop or restart an allowed service without authenticating.Local Unix-socket access is different: it is restricted through the socket’s filesystem permissions and should continue to work.
How I did it
KillProcessrequests when no client authentication method is configured.How to verify it
git diff --checkpasses. The focused Go tests were not run locally because this host does not have the Go/build environment; repository CI will provide that result.Which release branch to backport (provide reason below if selected)
No backport requested.
Tested branch
Test result
Focused regression tests were added. Repository CI is pending.
Description for the changelog
Require authentication for remote gNOI
KillProcessrequests.Link to config_db schema for YANG module changes
N/A
A picture of a cute animal (not mandatory but encouraged)