sonic-host-services changes for OC platform components SWComp - #413
niranjanivivek wants to merge 1 commit into
Conversation
|
/azp run |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
Hi, there are workflow run(s) waiting for approval, you may be first-time contributor. I will notify maintainers to help approve once PR is approved. Thanks! ---Powered by SONiC BuildBot
|
7e6e35f to
1f66d8a
Compare
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
1f66d8a to
2156163
Compare
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
2156163 to
ce51e27
Compare
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
ce51e27 to
2850897
Compare
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
@kishanps Please review the PR. |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
@kishanps Please review the PR. |
|
@kishanps Please review and approve |
2850897 to
9849c40
Compare
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
9849c40 to
3b0f235
Compare
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
…re componenents model Signed-off-by: Niranjani Vivek <niranjaniv@google.com>
3b0f235 to
6b0de44
Compare
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
@kishanps Please review and confirm the changes |
|
@niranjanivivek Can you update the description with a table of the openconfig paths for which the support is being added and what are the corresponding redis db paths and a short description of that path. For eg, |
The description is now added. |
|
@niranjanivivek Can you check whether these 2 fields are already present in upstream (without your changes) and if your changes would overwrite the current values? CONFIG DB - DEVICE_METADATA|localhost |
Hi Kishan, I checked the existing behavior and confirmed that the below parameters are not already present/upstreamed.
The script holds only place holders for the below.
Kindly suggest whether these can be retained in script and removed from description. |
Placeholder should be fine but please update the description accordingly. I am approving the changes but also check if CHASSIS_INFO|chassis is an existing field and if the new changes will overwrite. |
|
Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
1 similar comment
|
Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
Hi Kishan, Thanks for approving. The new changes are not overwriting anything which is already present. |
|
Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
1 similar comment
|
Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
The changes are made for OpenConfig platform components - Software Components Model
Code changes in sonic-mgmt-common - PR#230
Below table describes the openconfig paths for software components supported and the corresponding redis DB paths
The table below describes the placeholder in this script for other openconfig paths and the corresponding redis DB paths. The translib support can be added based on requirement.