[action] [PR:404] [gnoi_shutdown_daemon] Log gNOI Reboot failure details - #417
Merged
Merged
Conversation
#### Why I did it When the gNOI Reboot (HALT) call to a DPU failed during graceful shutdown, the daemon only logged "Reboot command failed" and hid stderr. That made failures hard to debug. ##### Work item tracking - Microsoft ADO **(number only)**: N/A #### How I did it - Stopped hiding stderr on the gNOI Reboot call. - Added the return code, target IP:port, and the real error text to the log message. #### How to verify it - Run a graceful shutdown where the gNOI Reboot call fails (for example, an unreachable DPU). - Check syslog and confirm the log now shows rc, target IP:port, and the gNOI error text. #### Description for the changelog Log full gNOI Reboot failure details (rc, target, stderr) in gnoi_shutdown_daemon. Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com>
Author
|
Original PR: #404 |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
When the gNOI Reboot (HALT) call to a DPU failed during graceful shutdown, the daemon only logged
"Reboot command failed" and hid stderr. That made failures hard to debug.
Work item tracking
How I did it
How to verify it
Description for the changelog
Log full gNOI Reboot failure details (rc, target, stderr) in gnoi_shutdown_daemon.
Signed-off-by: Sonic Build Admin sonicbld@microsoft.com