Conversation
Signed-off-by: Dennis Lanov <dennis.lanov@gmail.com>
Collaborator
|
/azp run |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Collaborator
|
Hi, there are workflow run(s) waiting for approval, you may be first-time contributor. I will notify maintainers to help approve once PR is approved. Thanks! ---Powered by SONiC BuildBot
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Reassert the peer Standby forwarding state when the SoC-side state unexpectedly resets to Active while the peer link remains unknown.
Fixes #285
Type of change
Approach
What is the motivation for this PR?
When the peer link becomes unknown, linkmgrd switches the peer forwarding state to Standby. If the SoC-side agent later restarts and reports the peer state as Active again, linkmgrd currently accepts that state without reasserting Standby, even though the conditions requiring Standby have not changed.
Work item tracking
How did you do it?
After processing a peer mux state notification, check the current state-machine conditions. If the peer reports Active while:
linkmgrd reasserts the peer Standby state.
The decision is based on the current FSM state rather than
mLastSetPeerMuxState, which can contain a stale Standby value after a genuine peer recovery.How did you verify/test it?
git diff --checkpassesAny platform specific information?
None.
Documentation
No documentation changes required.