link-prober: Reject truncated command TLVs before dispatch - #353
Open
ashutosh-agrawal wants to merge 1 commit into
Open
ashutosh-agrawal wants to merge 1 commit into
ashutosh-agrawal wants to merge 1 commit into
Conversation
Signed-off-by: Ashutosh Agrawal <ashu@cisco.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Check the payload length before processing a command TLV.
A command TLV is expected to contain one
Commandvalue. We already verify that the TLV fits within the received packet, but we were not checking that its payload was large enough to hold the command itself. If the length was zero, the handler could read the next byte as the command.This PR adds the missing length check. Valid command TLVs continue to work as before.
Type of change
Approach
What is the motivation for this PR?
Make sure a command is read only when it is part of the declared TLV payload.
Work item tracking
How did you do it?
Check that the payload is at least
sizeof(Command)before passing the TLV to the command handler. Stop processing the TLV sequence when the command payload is too short.How did you verify/test it?
Added a test with a zero-length command TLV and verified that it does not generate a switch-active event.
LinkProberMockTest.LinkProberActiveStandbyIgnoresShortCommandTlv: passed.Any platform specific information?
N/A
Documentation
N/A