[action] [PR:22565] fix default route for t0-isolated topo - #22933
Merged
Merged
Conversation
Description of PR
Summary:
In t0-isolated topo, the default route may come from PT0 or T1, and PT0 is preferred due to shorter AS path. Update the test case to suit it.
Fixes default route for t0-isolated topo.
route/test_default_route.py::test_default_route_with_bgp_flap FAILED [ 75%]
......
logging.info("peer intf ip from tb {}".format(upstream_neigh_ip))
> pytest_assert(len(nexthops) == len(upstream_neigh_ip),
"Default route nexthops doesn't match the testbed topology")
E Failed: Default route nexthops doesn't match the testbed topology
Signed-off-by: Dashuai Zhang <dashuaizhang@microsoft.com>
Signed-off-by: mssonicbld <sonicbld@microsoft.com>
mssonicbld
requested review from
prabhataravind,
r12f,
wangxin,
wenyiz2021 and
xwjiang-ms
as code owners
March 13, 2026 00:47
12 tasks
Collaborator
Author
|
Original PR: #22565 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
In t0-isolated topo, the default route may come from PT0 or T1, and PT0 is preferred due to shorter AS path. Update the test case to suit it.
Fixes default route for t0-isolated topo.
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix default route announcement from PT0 in t0-isolated topo
How did you do it?
How did you verify/test it?
local testbed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation