Skip to content

Fix drop-check in test_acl_drop and test_acl_egress_drop for test_drop_counters.py #27815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AkeelAli wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −2
Open

Fix drop-check in test_acl_drop and test_acl_egress_drop for test_drop_counters.py #27815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/common/helpers/drop_counters/drop_counters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def ensure_no_l3_drops(duthost, packets_count):
unexpected_drops = {}
for iface, value in list(intf_l3_counters.items()):
try:
rx_err_value = int(value[RX_ERR])
rx_err_value = int(str(value[RX_ERR]).replace(",", ""))
except ValueError as err:
logger.info("Unable to verify L3 drops on iface {}, L3 counters may not be supported on this platform\n{}"
.format(iface, err))
Expand All @@ -83,7 +83,7 @@ def ensure_no_l2_drops(duthost, packets_count):
unexpected_drops = {}
for iface, value in list(intf_l2_counters.items()):
try:
rx_drp_value = int(value[RX_DRP])
rx_drp_value = int(str(value[RX_DRP]).replace(",", ""))
except ValueError as err:
logger.warning("Unable to verify L2 drops on iface {}\n{}".format(iface, err))
continue
Expand Down
1 change: 1 addition & 0 deletions tests/drop_packets/combined_drop_counters.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,4 @@ acl_l2:
- "x86_64-arista.*"
- "x86_64-cel_seastone.*"
- "x86_64-nokia.*"
- "x86_64-kvm_x86_64-r0" # VPP
Loading