Restart gNMI after updating test authentication - #28016
Open
ashutosh-agrawal wants to merge 2 commits into
Open
ashutosh-agrawal wants to merge 2 commits into
ashutosh-agrawal wants to merge 2 commits into
Conversation
Signed-off-by: Ashutosh Agrawal <ashu@cisco.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Collaborator
|
/azp run |
github-actions
Bot
requested review from
cyw233,
xwjiang-ms and
yutongzhang-microsoft
September 18, 2026 18:56
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Signed-off-by: Ashutosh Agrawal <ashu@cisco.com>
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Update the IPv6 management telemetry test to restart the gNMI service after
changing its temporary authentication configuration. The gNMI launch arguments
are generated when the service starts, so reloading supervisord does not
reliably apply a changed
user_authvalue.The test now preserves and restores the original
user_authconfiguration andwaits for both the service and its TCP listener before sending the request. The
shared streaming telemetry context also restores
client_authwhen a testraises an exception.
Fixes #28017
Type of change
Back port request
Tracking issue/work item for backport/cherry-pick request (GitHub issue or Microsoft ADO): #28017
Failure type: regression
Tested branch
Test result
python3 -m py_compile tests/common/helpers/telemetry_helper.py tests/ip/test_mgmt_ipv6_only.py(passed)Approach
What is the motivation for this PR?
test_telemetry_output_ipv6_onlytemporarily disables gNMI userauthentication before invoking a client without credentials. The previous
supervisor reload could leave the running gNMI process using its earlier
authentication mode, causing the request to be rejected as unauthenticated.
How did you do it?
user_authvalue, including an absent field.user_auth=noneand wait for the TCPlistener before querying it.
a
finallyblock.client_authwhen thetest body fails.
How did you verify/test it?
python3 -m py_compile tests/common/helpers/telemetry_helper.py tests/ip/test_mgmt_ipv6_only.pyAny platform specific information?
No.
Supported testbed topology if it's a new test case?
N/A. This updates an existing IPv6 management test.
Documentation
N/A.