Conversation
Signed-off-by: Ariz Zubair <arizzubair@microsoft.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Collaborator
|
/azp run |
github-actions
Bot
requested review from
rawal01,
xwjiang-ms and
yutongzhang-microsoft
September 18, 2026 19:56
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Increase the SFP reset interface shutdown wait scaling from 1% to 10% per interface. This gives larger interface batches enough time to complete shutdown before they are brought back up.
Fixes # (issue): N/A
Type of change
Back port request
Tracking issue/work item for backport/cherry-pick request (GitHub issue or Microsoft ADO): N/A
Failure type: N/A
Tested branch
Test result
git diff --checkandpython3 -m py_compile tests/platform_tests/api/test_sfp.py.Approach
What is the motivation for this PR?
The existing 1% per-interface scale factor can leave too little shutdown settling time when an SFP reset requires many interfaces to be flapped.
How did you do it?
Changed the per-interface shutdown wait scale factor from
0.01to0.1, while retaining the existing minimum scale factor of 1.How did you verify/test it?
Verified whitespace and patch formatting with
git diff --check, and compiled the updated test module withpython3 -m py_compile.Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A; this is not a new test case.
Documentation
N/A; no user-facing behavior or documentation changed.