[schema]: Add MACsec MKA state table names - #1251
Open
liamkearney-msft wants to merge 1 commit into
Open
liamkearney-msft wants to merge 1 commit into
liamkearney-msft wants to merge 1 commit into
Conversation
Signed-off-by: Liam Kearney <liamkearney@microsoft.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
🟢 Approval recommended
The reviewed schema additions have no unresolved issues.
Pull request overview
Adds State DB table-name macros for MACsec MKA session and participant state.
Changes:
- Defines
STATE_MACSEC_MKA_SESSION_TABLE_NAME. - Defines
STATE_MACSEC_MKA_PARTICIPANT_TABLE_NAME.
File summaries
| File | Description |
|---|---|
common/schema.h |
Adds MACsec MKA State DB table-name constants. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add shared schema constants for the two namespace-local STATE_DB tables used to publish MACsec MKA operational state:
STATE_MACSEC_MKA_SESSION_TABLE_NAME(MACSEC_MKA_SESSION_TABLE)STATE_MACSEC_MKA_PARTICIPANT_TABLE_NAME(MACSEC_MKA_PARTICIPANT_TABLE)Design and companion changes
Dependency order: this PR → sonic-net/sonic-swss#4827 → sonic-net/sonic-buildimage#29102. The WPA PR supplies the frozen interface consumed by the SWSS implementation.
Validation
git diff --checkpassed.common/schema.h; there is no dedicated unit-test surface for these declarations.