docs(cli): record the whoami fix under 0.14.0, the version that shipped it - #57
Merged
Merged
Conversation
…ed it #53 landed on main without a changeset, so `sonilo whoami`'s exit-code change rode out inside 0.14.0 with nothing in that release's notes. The version number is right — it went out in a minor bump, which is the correct slot for a behaviour change at 0.x — only the changelog was silent. Written against the existing 0.14.0 heading rather than as a new changeset, so no phantom 0.15.0 gets published for a change that is already in users' hands. Anyone whose script broke on `whoami` returning 1 can now find the version that did it. Supersedes #54, which proposed the changeset and would have dated this to the next release instead.
Lightsage docs evalsWaiting for the staging docs URL before running evals. Lightsage will start the selected PR evals automatically when GitHub reports a successful docs deployment for this PR. This usually happens within 15 minutes. Commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sonilo whoami's exit-code change (#53) shipped insonilo-cli@0.14.0but is absent from that release's notes: #53 landed onmainwithout a changeset, and changesets versions whatever code is onmainregardless. Verified —git merge-base --is-ancestor 8ada33d sonilo-cli@0.14.0passes, and the published 0.14.0 tarball'srunWhoamialready returnsfalse(exit 1) when there is no credential.The version number is fine: it rode out in a minor bump, which is the right slot for a behaviour change at 0.x. Only the changelog was silent.
Why edit 0.14.0 instead of merging #54
#54 adds the changeset that was missing. Merging it now would bump
sonilo-clito 0.15.0 and date the note to that release — but the change is already in users' hands at 0.14.0. Someone whose script broke onwhoamireturning 1 would look up 0.14.0, find nothing, and be told the change belongs to a version they don't have.Writing it against the existing
## 0.14.0heading records it against the version that actually contains it, and publishes no phantom release.#54 should be closed in favour of this.
Also
The GitHub Release notes for
sonilo-cli@0.14.0are being updated to match.