Fix STT language configuration and dialer lifecycle - #75
Merged
Conversation
This was referenced Aug 13, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
languageor any backend receives unsupportedlanguageHints, with actionable Chinese locale guidancezh-CN/zh-TWas the Chinese pathFixes #74.
This also addresses the call/dial execution failure reported in the S23 Ultra discussion.
Compatibility and risk
SpeechConfignow rejects settings that were previously silently ignored. Existing Parakeet integrations using a concretelanguageor non-emptylanguageHintsmust remove those settings or selectNEMOTRON_MULTILINGUALfor prompt-conditioned recognition.Call actions still use Android
ACTION_DIAL; the app does not place calls directly and adds no permissions, network access, or data handling.Test plan
./gradlew :sdk:test./gradlew :sdk:assembleDebug./gradlew :control-demo:testDebugUnitTest./gradlew :control-demo:assembleDebug./gradlew :control-demo:assembleReleasetel:123dialer intent, returned to the app, and completed a second volume commandThe full
:sdk:connectedAndroidTestsuite was not run; the targeted arm64 control-demo flow above exercised the Android lifecycle regression with real on-device models.