Make the VAD device timeout measure VAD work - #78
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move synthesized fixture generation ahead of the Silero VAD event timeouts. The timeout now measures the interval after audio is ready, rather than including Kokoro fixture generation.
Why
During the complete pre-release device suite, this test started its 30-second SpeechStarted timeout and then synchronously generated its audio fixture. On the loaded arm64 emulator, fixture synthesis took about 55 seconds. SpeechStarted was emitted correctly once audio was finally pushed, but the timer had already expired.
This is a test-only timing correction. SDK and runtime behavior are unchanged.
Test plan
Related
Found while running the mandatory full connectedAndroidTest gate before the v0.0.17 release.