Open
Conversation
A user's machine may have the sequence.editor set, which may configure a separate editor rebases. Add instructions to unset sequence.editor, making Commit the default editor.
sonnyp
reviewed
Aug 31, 2023
Comment on lines
-39
to
+40
| git_text.label = `<tt>git config --global core.editor "${command}"</tt>`; | ||
| git_text.label = `<tt>git config --global core.editor "${command}"\n` + | ||
| 'git config --global --unset sequence.editor</tt>'; |
Owner
There was a problem hiding this comment.
I have 2 issues with this
- Commit isn't a very good rebase editor rfc: Add dedicated rebase UI? #81
- I don't want to make the command too complicated.
Slightly off-topic but now that Commit has read/write permissions to the user home directory, we could remove the commands and use buttons that run the commands directly.
Similar to Junction
I'll think about it for the next release.
Comment on lines
+30
to
+43
| settings.bind( | ||
| "window-width", | ||
| window, | ||
| "default-width", | ||
| Gio.SettingsBindFlags.DEFAULT, | ||
| ); | ||
|
|
||
| settings.bind( | ||
| "window-height", | ||
| window, | ||
| "default-height", | ||
| Gio.SettingsBindFlags.DEFAULT, | ||
| ); | ||
|
|
Owner
There was a problem hiding this comment.
Why do you want Commit to remember window size?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a couple ideas...