core/ops/fft: Stft::axes_mapping unlocks pulsification on non-STFT axes#2331
Merged
Conversation
kali
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stftis the only typed op left incore/src/ops/fft.rswithout anaxes_mapping. Add one. The mapping is custom because Stft is not rank-preserving: it inserts a frame axis atop.axis + 1.The mapping declares:
op.axis): 1-to-1 input ↔ output (natural).op.axis(time) ↔ outputop.axis(n_frames, same position, smaller dim).op.axis + 1: output-only (the inserted frame axis).op.axis + 1..rank, including the complex pair) ↔ output dims shifted right by 1.Side effect:
PulseWrappingOpcan now handle a non-STFT streaming axis without bailing oncould not track pulsing axis. I don't have an in-the-wild model that needs this today; the typical STFT use case streams the time axis, whichstft_pulsifyalready handles. The patch is for structural completeness (everyTypedOpshould declare its axes contract) and symmetry with the Fft fix in #2261.