Skip to content

MXL Domain ID patch fix #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lo-simon merged 2 commits into from
Aug 18, 2026
Merged

MXL Domain ID patch fix #174

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ce1a96
Transform MXL Domain to auto on PATCH
jonathan-r-thorpe Aug 17, 2026
083f24d
Merge branch 'master' into mxl-domain-auto
jonathan-r-thorpe Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Development/src/components/makeConnection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const oneToOneTransportParams = {
'connection_authorization',
'connection_uri',
],
'urn:x-nmos:transport:mxl': ['mxl_domain_id', 'mxl_flow_id'],
'urn:x-nmos:transport:mxl': ['mxl_flow_id'],
};

// create an array mapping receiver leg to sender leg
Expand Down Expand Up @@ -142,6 +142,12 @@ const makePatchDataWithTransportParams = (data, options) => {
case 'urn:x-nmos:transport:websocket':
break;
case 'urn:x-nmos:transport:mxl':
// When patching in a multi-node cluster environment where flows are replicated across nodes,
// the MXL domain a Sender writes to may be different to the MXL domain the Receiver reads from.
// For this reason it is unsafe to patch the domain id verbatim, and instead "auto" is a better default.
legMap.forEach((senderLeg, receiverLeg) => {
set(patchParams[receiverLeg], 'mxl_domain_id', 'auto');
});
break;
default:
break;
Expand Down