Proxy Query and Device NCP WebSockets through the NMOS Bridge - #177
Merged
Conversation
Bring the websocket proxy plan onto nmos-bridge and record a local Envoy 1.31 spike: Query subscription grains and IS-12 command/response both work through upgrade routes with timeout 0s. Confirm NCP rejects HTTP health checks (426) and note adapter ws-scheme / health-check gaps before Case B.
Add a static registry_query_ws Envoy cluster and bridge path rewrite so bridge-aware clients can open grains without reaching the Registry query_ws port. Disable the HTTP buffer filter on the upgrade route. Document the path, REGISTRY_QUERY_WS_URL upstream, and long-lived WebSocket timeouts.
Add ncp to CONTROL_TYPES with ws upstreams, TCP health checks, and upgrade routes that disable the HTTP buffer filter. Under Forced Bridge, IS-12 Browser launch uses the bridge NCP path instead of the Device control href.
garethsb
force-pushed
the
feature/query-websocket-proxy
branch
from
August 20, 2026 11:04
88b7b54 to
dd0d5a4
Compare
Show POST /map/activations/ beside the Connection PATCH so both HTTP Device APIs use the same origin-then-path rewrite as NCP. Signed-off-by: Gareth Sylvester-Bradley <garethsb@nvidia.com>
lo-simon
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/x-nmos-bridge/v1.0/query/...(static rewrite to the Registry Query WebSocket listener,REGISTRY_QUERY_WS_URLfor the adapter/upstream)./x-nmos-bridge/.../ncp/...(TCP health checks, HTTP buffer filter disabled on upgrade routes). Forced Bridge remaps IS-12 Browser launch to the bridge path.nmos-bridge/docs/.Test plan
websocat) vs direct Registryquery_ws_port.href; Forced Bridge uses the Envoy NCP path; command/response works on both.ws/wsscontrols get TCP health checks, not HTTP (NCP 426).