Make IS-08 Channel Mapping editable - #178
Merged
Merged
Conversation
Document Show/Edit (not API staged), diff-only activations with scheduled modes, soft cap warnings, and a separate Activations tab.
Open Edit from the Active Map tab, keep a local draft, and POST only the changed channels through dataProvider UPDATE of devices. Require Jest to find tests now that the first suite exists. Signed-off-by: Gareth Sylvester-Bradley <garethsb@nvidia.com>
Keep every mapping control clickable. Unselected cells that the Output does not list use a faded warning colour; selected ones keep the check in the same warning colour so a Node can still be tested with a POST. Signed-off-by: Gareth Sylvester-Bradley <garethsb@nvidia.com>
Predict incomplete blocks and non-fixed offsets from the draft map, then show the highest-priority warning on selected cells. Leave Activate enabled. Signed-off-by: Gareth Sylvester-Bradley <garethsb@nvidia.com>
POST relative and absolute modes with requested_time, list pending activations from $activations, and cancel them with DELETE. Signed-off-by: Gareth Sylvester-Bradley <garethsb@nvidia.com>
Signed-off-by: Gareth Sylvester-Bradley <garethsb@nvidia.com>
Use a non-interactive MappingCellTooltip on matrix cells so the popover does not block the cell below or stay open after the pointer leaves. Keep MappingHeadTooltip interactive for header names and chip links. Signed-off-by: Gareth Sylvester-Bradley <garethsb@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dataProviderUPDATEofdevices.routable_inputs,block_sizeandreorderingon the matrix without blocking Activate, so a Node can still be tested with a predicted-invalid POST.requested_time) matching Connection Edit, a pending Activations show tab, and Cancel viaDELETE …/map/activations/{id}.Test plan
nmos-cpp-nodeupdates Active Map and a later Edit seeds from that map.routable_inputs/ incomplete blocks / non-fixed offset show the highest-priority warning; Activate still posts.requested_time(e.g.300:0) appears on Activations and can be cancelled.$channelmappingAPI.yarn testinDevelopment/(Jest now fails if no tests are found).