handle_auth_response: wrong secret and raise error#51
Merged
dgw merged 1 commit intosopel-irc:masterfrom Dec 4, 2019
Merged
Conversation
Member
|
Definitely appreciate the initiative! However we already have more comprehensive changes to the database stuff being worked on in #49. That said, if you want to extract your changes to the webhook |
bbuccianti
changed the title
dgw
reviewed
Dec 4, 2019
Member
dgw
left a comment
dgw
left a comment
There was a problem hiding this comment.
I see you've already learned how to force-push branches—that's a useful skill! Are you sure you're "just a student"? 😛 I have only minor comments.
Co-Authored-By: dgw <dgw@technobabbl.es>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm just a student trying to learn so I really want your feedback guys!
Thanks a lot!