Skip to content

[Chore] #142 - 스토리북 MDS 의존성 로컬 패키지 참조로 변경 - #143

Merged
yungu0010 merged 2 commits into
defaultfrom
chore/#142-local-package-reference
Jul 7, 2026
Merged

yungu0010 merged 2 commits into
defaultfrom
chore/#142-local-package-reference

Conversation

@yungu0010

@yungu0010 yungu0010 commented Jul 7, 2026 •

Copy link
Copy Markdown
Member

🌴 PR 요약

🌱 작업한 브랜치

🌱 PR Point

  • MDSStoryBook의 MDS 패키지 참조를 원격에서 로컬로 변경했습니다.
  • 체크아웃된 브랜치의 MDS 소스가 스토리북 빌드에 바로 반영되어, 컴포넌트 작업 시 프로젝트 파일의 revision pin을 수동으로 갱신할 필요가 없습니다.
  • relativePath는 ..(저장소 루트의 Package.swift)로 지정해, 저장소를 어떤 폴더 이름으로 클론해도 동작합니다.

📌 참고 사항

  • 외부 앱(SOPT-iOS)에서 MDS를 사용할 때는 별도로 태그 기반 버전 참조(from: "x.y.z")를 도입하도록 문서화 필요
  • 스토리북은 저장소 내부이기 때문에 로컬로 변경해도 무방하다고 판단했습니다.

📸 스크린샷

생략

📮 관련 이슈

@coderabbitai

coderabbitai Bot commented Jul 7, 2026 •

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@yungu0010, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 45 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7c2a4140-3a39-410c-a99e-bf1ed0bb9f1c

📥 Commits

Reviewing files that changed from the base of the PR and between 26ead8b and f3e7d82.

📒 Files selected for processing (1)
  • MDSStoryBook/MDSStoryBook/Component/Input/TextAreaViewController.swift

Walkthrough

MDSStoryBook의 Xcode 프로젝트 파일에서 MDS 패키지 의존성 구성을 원격 Swift 패키지 참조(revision 고정)에서 로컬 패키지 참조(relativePath "..")로 변경함. 관련 productRef 식별자가 모든 참조 위치에서 새 ID로 교체됨.

Changes

로컬 패키지 참조 전환

Layer / File(s) Summary
로컬 패키지 참조 정의
MDSStoryBook/MDSStoryBook.xcodeproj/project.pbxproj
PBXProject의 packageReferences에서 XCRemoteSwiftPackageReference("SOPT-iOS-MDS")를 제거하고 XCLocalSwiftPackageReference(relativePath="..")를 추가하며, XCSwiftPackageProductDependency의 MDS 엔트리를 새 ID로 교체함.
빌드 산출물 및 타깃 참조 업데이트
MDSStoryBook/MDSStoryBook.xcodeproj/project.pbxproj
PBXBuildFile, PBXFrameworksBuildPhase, PBXNativeTarget의 packageProductDependencies에서 MDS를 가리키는 productRef 식별자를 새 값으로 교체함.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • sopt-makers/SOPT-iOS-MDS#52: 동일한 project.pbxproj 파일에서 MDS 제품의 패키지 참조 방식(relativePath/productRef)을 변경한 이력이 있음.

Suggested labels: chore

Poem

원격에서 로컬로, 토끼처럼 폴짝 🐇
pin 고정은 이제 안녕, 바이바이~
브랜치 코드 바로바로 스토리북에 쏙!
productRef 새 옷 입고 신나게 빌드
당근 같은 코드 리뷰, 오늘도 두근두근 🥕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed 이슈 #142의 핵심 요구사항인 원격 참조 제거, 로컬 참조 전환, 빌드 확인을 충족합니다.
Out of Scope Changes check ✅ Passed 변경은 pbxproj의 패키지 참조 전환에만 국한되어 있어 범위를 벗어난 수정이 보이지 않습니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed 제목이 스토리북의 MDS 의존성을 로컬 패키지 참조로 바꾸는 핵심 변경을 정확히 요약합니다.
Description check ✅ Passed 설명이 원격 MDS 참조를 로컬로 전환한 목적과 영향이 변경사항과 잘 일치합니다.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/#142-local-package-reference

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yungu0010
yungu0010 requested a review from juri123123 July 7, 2026 05:14
@yungu0010 yungu0010 self-assigned this Jul 7, 2026
@yungu0010 yungu0010 added the chore label Jul 7, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
MDSStoryBook/MDSStoryBook.xcodeproj/project.pbxproj (1)

117-117: 🧹 Nitpick | 🔵 Trivial

참고: relativePath ".."는 모노레포 체크아웃 구조에 의존.

로컬 패키지 참조는 MDSStoryBook.xcodeproj가 저장소 루트 하위 MDSStoryBook/ 폴더에 위치하고 저장소 전체가 체크아웃되어 있다는 전제에 의존합니다. PR 목적상 Storybook 내부 개발 용도로 의도된 변경이라 문제는 없으나, 향후 CI 파이프라인이 MDSStoryBook 폴더만 별도로 체크아웃하는 방식으로 바뀌면 패키지 리졸브가 실패할 수 있다는 점을 참고하시기 바랍니다.

Also applies to: 365-370

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@MDSStoryBook/MDSStoryBook.xcodeproj/project.pbxproj` at line 117, The local
Swift package reference currently uses a parent-directory relative path, which
only works when the full monorepo layout is present. Update the
XCLocalSwiftPackageReference entries in MDSStoryBook.xcodeproj so the package
path is resilient to the intended checkout strategy, or switch to a reference
that does not depend on the workspace being rooted above MDSStoryBook. Make the
same adjustment for the related package reference entries around the same block
so the project resolves consistently in CI and local opens.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@MDSStoryBook/MDSStoryBook.xcodeproj/project.pbxproj`:
- Line 117: The local Swift package reference currently uses a parent-directory
relative path, which only works when the full monorepo layout is present. Update
the XCLocalSwiftPackageReference entries in MDSStoryBook.xcodeproj so the
package path is resilient to the intended checkout strategy, or switch to a
reference that does not depend on the workspace being rooted above MDSStoryBook.
Make the same adjustment for the related package reference entries around the
same block so the project resolves consistently in CI and local opens.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a1719b7e-d21e-490e-9bac-0be95245b0d7

📥 Commits

Reviewing files that changed from the base of the PR and between 16c0ba3 and 26ead8b.

📒 Files selected for processing (1)
  • MDSStoryBook/MDSStoryBook.xcodeproj/project.pbxproj

@yungu0010

Copy link
Copy Markdown
Member Author

f3e7d82: #138 머지에 빠졌던 카탈로그 TextArea maxLength 100→200 변경(2fe1c74)을 cherry-pick으로 추가했습니다.

@yungu0010
yungu0010 merged commit 7445f71 into default Jul 7, 2026
1 check passed
@yungu0010
yungu0010 deleted the chore/#142-local-package-reference branch July 7, 2026 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Chore] 스토리북 MDS 의존성을 로컬 패키지 참조로 변경

2 participants