[Chore] #142 - 스토리북 MDS 의존성 로컬 패키지 참조로 변경 - #143
Conversation
|
Warning Review limit reached
Next review available in: 45 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughMDSStoryBook의 Xcode 프로젝트 파일에서 MDS 패키지 의존성 구성을 원격 Swift 패키지 참조(revision 고정)에서 로컬 패키지 참조(relativePath "..")로 변경함. 관련 productRef 식별자가 모든 참조 위치에서 새 ID로 교체됨. Changes로컬 패키지 참조 전환
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
MDSStoryBook/MDSStoryBook.xcodeproj/project.pbxproj (1)
117-117: 🧹 Nitpick | 🔵 Trivial참고:
relativePath ".."는 모노레포 체크아웃 구조에 의존.로컬 패키지 참조는
MDSStoryBook.xcodeproj가 저장소 루트 하위MDSStoryBook/폴더에 위치하고 저장소 전체가 체크아웃되어 있다는 전제에 의존합니다. PR 목적상 Storybook 내부 개발 용도로 의도된 변경이라 문제는 없으나, 향후 CI 파이프라인이MDSStoryBook폴더만 별도로 체크아웃하는 방식으로 바뀌면 패키지 리졸브가 실패할 수 있다는 점을 참고하시기 바랍니다.Also applies to: 365-370
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@MDSStoryBook/MDSStoryBook.xcodeproj/project.pbxproj` at line 117, The local Swift package reference currently uses a parent-directory relative path, which only works when the full monorepo layout is present. Update the XCLocalSwiftPackageReference entries in MDSStoryBook.xcodeproj so the package path is resilient to the intended checkout strategy, or switch to a reference that does not depend on the workspace being rooted above MDSStoryBook. Make the same adjustment for the related package reference entries around the same block so the project resolves consistently in CI and local opens.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@MDSStoryBook/MDSStoryBook.xcodeproj/project.pbxproj`:
- Line 117: The local Swift package reference currently uses a parent-directory
relative path, which only works when the full monorepo layout is present. Update
the XCLocalSwiftPackageReference entries in MDSStoryBook.xcodeproj so the
package path is resilient to the intended checkout strategy, or switch to a
reference that does not depend on the workspace being rooted above MDSStoryBook.
Make the same adjustment for the related package reference entries around the
same block so the project resolves consistently in CI and local opens.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a1719b7e-d21e-490e-9bac-0be95245b0d7
📒 Files selected for processing (1)
MDSStoryBook/MDSStoryBook.xcodeproj/project.pbxproj
🌴 PR 요약
🌱 작업한 브랜치
🌱 PR Point
..(저장소 루트의Package.swift)로 지정해, 저장소를 어떤 폴더 이름으로 클론해도 동작합니다.📌 참고 사항
from: "x.y.z")를 도입하도록 문서화 필요📸 스크린샷
생략
📮 관련 이슈