Skip to content

fix: remove dead NotificationProvider and re-enable React Hooks lint rules (#412 #413) - #446

Merged
zachyo merged 1 commit into
soropad:masterfrom
Amas-01:fix/412-413-notification-provider-and-hooks-lint
Sep 2, 2026
Merged

fix: remove dead NotificationProvider and re-enable React Hooks lint rules (#412 #413)#446
zachyo merged 1 commit into
soropad:masterfrom
Amas-01:fix/412-413-notification-provider-and-hooks-lint

Conversation

@Amas-01

@Amas-01 Amas-01 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

Closes #412
Closes #413

What changed

#412 — Remove dead NotificationProvider

  • Removed NotificationProvider mount from layout.tsx
  • Deleted NotificationProvider.tsx
  • Deleted NotificationProvider.test.tsx
  • Confirmed ToastProvider is the only active notification system (13 consumers)

#413 — Re-enable React Hooks lint rules

  • Enabled five rules as "error": set-state-in-effect, refs, static-components, preserve-manual-memoization,
    incompatible-library
  • Fixed or documented all hits; promoted rules to "error"
  • Added inline disables with comments where rules genuinely cannot be satisfied

Why

How verified

  • npm run lint: 5 rules enabled as "error", 0 remaining hits
  • npm run test: no new failures; identical to base (all pre-existing failures are in untouched files, e.g.
    recentTokens/adminActions/transactionSimulator/e2e)
  • npm run build / tsc: my changed files typecheck clean; the only failures are pre-existing parse errors in
    ClaimVesting.tsx and useDeployToken.ts plus Google Fonts network fetch — none caused by this PR
  • Toasts still work in all 13 consumer files
  • No console errors about missing provider

Provider decision

  • ToastProvider retained (active, 13 consumers)
  • NotificationProvider removed (no consumers, abandoned)
  • Future notification work (e.g., Discord/Telegram Webhook Alerts #95 webhooks) will build on ToastProvider

Lint rules decision

  • All five rules now enabled as "error"
  • Inline disables used only where necessary, with comments
  • react-hooks/set-state-in-effect inline disables for legitimate external-store (localStorage) seeding and fetch-on-
    mount effects

@drips-wave

drips-wave Bot commented Aug 31, 2026

Copy link
Copy Markdown

@Amas-01 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@zachyo
zachyo merged commit 9a1f4a2 into soropad:master Sep 2, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Five react-hooks lint rules are disabled repo-wide NotificationProvider is mounted on every page and cannot be reached

2 participants