fix: remove dead NotificationProvider and re-enable React Hooks lint rules (#412 #413) - #446
Merged
zachyo merged 1 commit intoSep 2, 2026
Conversation
|
@Amas-01 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #412
Closes #413
What changed
#412 — Remove dead NotificationProvider
NotificationProvidermount fromlayout.tsxNotificationProvider.tsxNotificationProvider.test.tsxToastProvideris the only active notification system (13 consumers)#413 — Re-enable React Hooks lint rules
incompatible-library
Why
How verified
recentTokens/adminActions/transactionSimulator/e2e)
ClaimVesting.tsxanduseDeployToken.tsplus Google Fonts network fetch — none caused by this PRProvider decision
Lint rules decision
react-hooks/set-state-in-effectinline disables for legitimate external-store (localStorage) seeding and fetch-on-mount effects