Skip to content

📝 CodeRabbit Chat: Fix Rust benchmark capability construction without cloning #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
claycuy merged 1 commit into from
Sep 12, 2026
Merged

📝 CodeRabbit Chat: Fix Rust benchmark capability construction without cloning #570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions rust/benches/normal/add_bench.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,17 @@
*/

use lightvm::{LightVM, types::capability::Capability};
fn main() {
let capabilities = vec![

fn capabilities() -> Vec<Capability> {
vec![
Capability::Control,
Capability::Debug,
Capability::Observe,
];
let mut vm = LightVM::new(capabilities.clone());
]
}

fn main() {
let mut vm = LightVM::new(capabilities());
let raw = r#"[
["val", "x"],
["push", 5],
Expand All @@ -26,7 +30,7 @@ fn main() {
let benchmark = vm.tools().bench("add_bench").expect("benchmark requires debug capability");
benchmark.run(
|| {
let mut vm = LightVM::new(capabilities.clone());
let mut vm = LightVM::new(capabilities());
vm.load(raw.into());
vm
},
Expand Down
14 changes: 9 additions & 5 deletions rust/benches/normal/assign_bench.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,22 @@
*/

use lightvm::{LightVM, types::capability::Capability};
fn main() {
let capabilities = vec![

fn capabilities() -> Vec<Capability> {
vec![
Capability::Control,
Capability::Debug,
Capability::Observe,
];
let mut vm = LightVM::new(capabilities.clone());
]
}

fn main() {
let mut vm = LightVM::new(capabilities());
let raw = r#"[["val", "x"], ["push", 5], ["set", "x"]]"#;
let benchmark = vm.tools().bench("assign_bench").expect("benchmark requires debug capability");
benchmark.run(
|| {
let mut vm = LightVM::new(capabilities.clone());
let mut vm = LightVM::new(capabilities());
vm.load(raw.into());
vm
},
Expand Down
14 changes: 9 additions & 5 deletions rust/benches/normal/concat_bench.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,17 @@
*/

use lightvm::{LightVM, types::capability::Capability};
fn main() {
let capabilities = vec![

fn capabilities() -> Vec<Capability> {
vec![
Capability::Control,
Capability::Debug,
Capability::Observe,
];
let mut vm = LightVM::new(capabilities.clone());
]
}

fn main() {
let mut vm = LightVM::new(capabilities());
let raw = r#"[
["val", "x"],
["push", "Hello from "],
Expand All @@ -25,7 +29,7 @@ fn main() {
let benchmark = vm.tools().bench("concat_bench").expect("benchmark requires debug capability");
benchmark.run(
|| {
let mut vm = LightVM::new(capabilities.clone());
let mut vm = LightVM::new(capabilities());
vm.load(raw.into());
vm
},
Expand Down
14 changes: 9 additions & 5 deletions rust/benches/normal/dead_code_bench.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,17 @@
*/

use lightvm::{LightVM, types::capability::Capability};
fn main() {
let capabilities = vec![

fn capabilities() -> Vec<Capability> {
vec![
Capability::Control,
Capability::Debug,
Capability::Observe,
];
let mut vm = LightVM::new(capabilities.clone());
]
}

fn main() {
let mut vm = LightVM::new(capabilities());
let raw = r#"[
["push", 5],
["push", 8],
Expand All @@ -30,7 +34,7 @@ fn main() {
.expect("benchmark requires debug capability");
benchmark.run(
|| {
let mut vm = LightVM::new(capabilities.clone());
let mut vm = LightVM::new(capabilities());
vm.load(raw.into());
vm
},
Expand Down
14 changes: 9 additions & 5 deletions rust/benches/normal/io_bench.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,22 @@
*/

use lightvm::{LightVM, types::capability::Capability};
fn main() {
let capabilities = vec![

fn capabilities() -> Vec<Capability> {
vec![
Capability::Control,
Capability::Debug,
Capability::Observe,
];
let mut vm = LightVM::new(capabilities.clone());
]
}

fn main() {
let mut vm = LightVM::new(capabilities());
let raw = r#"[["push", "Hello from LightVM!"], ["println"]]"#;
let benchmark = vm.tools().bench("io_bench").expect("benchmark requires debug capability");
benchmark.run(
|| {
let mut vm = LightVM::new(capabilities.clone());
let mut vm = LightVM::new(capabilities());
vm.load(raw.into());
vm
},
Expand Down
14 changes: 9 additions & 5 deletions rust/benches/optimize/add_bench.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,17 @@
*/

use lightvm::{LightVM, types::capability::Capability};
fn main() {
let capabilities = vec![

fn capabilities() -> Vec<Capability> {
vec![
Capability::Control,
Capability::Debug,
Capability::Observe,
];
let mut vm = LightVM::new(capabilities.clone());
]
}

fn main() {
let mut vm = LightVM::new(capabilities());
let raw = r#"[
["val", "x"],
["push", 5],
Expand All @@ -28,7 +32,7 @@ fn main() {
let benchmark = tools.bench("add_bench").expect("benchmark requires debug capability");
benchmark.run(
|| {
let mut vm = LightVM::new(capabilities.clone());
let mut vm = LightVM::new(capabilities());
vm.load(optimized_json.clone());
vm
},
Expand Down
14 changes: 9 additions & 5 deletions rust/benches/optimize/assign_bench.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,24 @@
*/

use lightvm::{LightVM, types::capability::Capability};
fn main() {
let capabilities = vec![

fn capabilities() -> Vec<Capability> {
vec![
Capability::Control,
Capability::Debug,
Capability::Observe,
];
let mut vm = LightVM::new(capabilities.clone());
]
}

fn main() {
let mut vm = LightVM::new(capabilities());
let raw = r#"[["val", "x"], ["push", 5], ["set", "x"]]"#;
let tools = vm.tools();
let optimized_json = tools.optimize_bytecode(raw);
let benchmark = tools.bench("assign_bench").expect("benchmark requires debug capability");
benchmark.run(
|| {
let mut vm = LightVM::new(capabilities.clone());
let mut vm = LightVM::new(capabilities());
vm.load(optimized_json.clone());
vm
},
Expand Down
14 changes: 9 additions & 5 deletions rust/benches/optimize/concat_bench.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,17 @@
*/

use lightvm::{LightVM, types::capability::Capability};
fn main() {
let capabilities = vec![

fn capabilities() -> Vec<Capability> {
vec![
Capability::Control,
Capability::Debug,
Capability::Observe,
];
let mut vm = LightVM::new(capabilities.clone());
]
}

fn main() {
let mut vm = LightVM::new(capabilities());
let raw = r#"[
["val", "x"],
["push", "Hello from "],
Expand All @@ -27,7 +31,7 @@ fn main() {
let benchmark = tools.bench("concat_bench").expect("benchmark requires debug capability");
benchmark.run(
|| {
let mut vm = LightVM::new(capabilities.clone());
let mut vm = LightVM::new(capabilities());
vm.load(optimized_json.clone());
vm
},
Expand Down
14 changes: 9 additions & 5 deletions rust/benches/optimize/dead_code_bench.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,17 @@
*/

use lightvm::{LightVM, types::capability::Capability};
fn main() {
let capabilities = vec![

fn capabilities() -> Vec<Capability> {
vec![
Capability::Control,
Capability::Debug,
Capability::Observe,
];
let mut vm = LightVM::new(capabilities.clone());
]
}

fn main() {
let mut vm = LightVM::new(capabilities());
let raw = r#"[
["push", 5],
["push", 8],
Expand All @@ -31,7 +35,7 @@ fn main() {
.expect("benchmark requires debug capability");
benchmark.run(
|| {
let mut vm = LightVM::new(capabilities.clone());
let mut vm = LightVM::new(capabilities());
vm.load(optimized_json.clone());
vm
},
Expand Down
14 changes: 9 additions & 5 deletions rust/benches/optimize/io_bench.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,24 @@
*/

use lightvm::{LightVM, types::capability::Capability};
fn main() {
let capabilities = vec![

fn capabilities() -> Vec<Capability> {
vec![
Capability::Control,
Capability::Debug,
Capability::Observe,
];
let mut vm = LightVM::new(capabilities.clone());
]
}

fn main() {
let mut vm = LightVM::new(capabilities());
let raw = r#"[["push", "Hello from LightVM!"], ["println"]]"#;
let tools = vm.tools();
let optimized_json = tools.optimize_bytecode(raw);
let benchmark = tools.bench("io_bench").expect("benchmark requires debug capability");
benchmark.run(
|| {
let mut vm = LightVM::new(capabilities.clone());
let mut vm = LightVM::new(capabilities());
vm.load(optimized_json.clone());
vm
},
Expand Down
Loading