-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Added diagnostic links to error messages #583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
1d77ca2
feat: Added diagnostic links to error messages
claycuy 8657c2c
📝 CodeRabbit Chat: Add VMError Diagnostic Links to Error Output (#584)
coderabbitai[bot] b162442
📝 CodeRabbit Chat: Refine Diagnostic Link Layout in VM Error Output (…
coderabbitai[bot] ba39242
📝 CodeRabbit Chat: Add configurable diagnostic links to VM error outp…
coderabbitai[bot] 7aa98e4
refactor: Clean up source code
claycuy 8d6d814
chore: Update typing files
claycuy 735cec5
📝 CodeRabbit Chat: Add diagnosticLinks to TypeScript ErrorOptions def…
coderabbitai[bot] 925fef7
feat: Add diagnostic links to generated ErrorOptions types (#588)
coderabbitai[bot] 1c1a881
📝 CodeRabbit Chat: Document diagnostic links and configuration APIs (…
coderabbitai[bot] ff138af
📝 CodeRabbit Chat: Synchronize Indonesian Quick Usage Documentation w…
coderabbitai[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Set the VM error mode before validation.
VMErrorformatting reads the thread-local configuration.optimize_bytecode_internalchecksCapability::Controlbefore setting this VM's mode.call_exported_internaldoes not set the mode before its capability, export, or function validation. After another VM runs on the same thread, these errors can use stalediagnostic_linksand other formatting flags.Move
set_mode(...)beforerequire(Capability::Control)inoptimize_bytecode_internal. Callset_mode(...)at the start ofcall_exported_internal, before its validation checks.🤖 Prompt for AI Agents