📝 CodeRabbit Chat: Enforce Numeric Type Validation for Power and Trigonometric Opcodes - #599
Merged
Merged
Conversation
…onometric Opcodes
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
Important Review skippedThis PR was authored by the user configured for CodeRabbit reviews. CodeRabbit does not review PRs authored by this user. It's recommended to use a dedicated user account to post CodeRabbit review feedback. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Essentials Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
8 tasks
claycuy
added a commit
that referenced
this pull request
Sep 15, 2026
* feat: Tighten the number type rules on math opcodes * 📝 CodeRabbit Chat: Reject Floating-Point Operands in Integer Arithmetic Opcodes (#597) Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * 📝 CodeRabbit Chat: Enforce Numeric Type Validation for Power and Trigonometric Opcodes (#599) Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * 📝 CodeRabbit Chat: Accept All Floating-Point Variants for Math Operations (#600) Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * 📝 CodeRabbit Chat: Tighten Type Validation for Bitwise and EXP Opcodes (#601) Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * 📝 CodeRabbit Chat: Standardize TypeMismatch Found-Type Messages Across Math Opcodes (#606) Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * 📝 CodeRabbit Chat: Restore Numeric Error Display Names and Validation Tests (#608) Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * 📝 CodeRabbit Chat: Validate numeric families in vector arithmetic opcodes (#609) Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * 📝 CodeRabbit Chat: Enforce float-family validation in logarithm opcodes (#610) Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * refactor: Clean up source code * 📝 CodeRabbit Chat: Reject Integer Operands for Float Arithmetic and Root Operations (#611) Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * 📝 CodeRabbit Chat: Enforce Numeric Family Validation in Vector Operations (#612) Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * 📝 CodeRabbit Chat: Enforce Float Validation for Scalar and Vector Trigonometry (#613) Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code changes was requested by @claycuy.
The following files were modified:
rust/src/instructions/math/arithmetic/cos_func.rsrust/src/instructions/math/arithmetic/pow_func.rsrust/src/instructions/math/arithmetic/powf_func.rsrust/src/instructions/math/arithmetic/powi_func.rsrust/src/instructions/math/arithmetic/sin_func.rsrust/src/instructions/math/arithmetic/tan_func.rs