Skip to content

Fixed indexing description mismatch with the actual indexing in _bidding_history #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Amir-Arsalan wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fixed indexing description mismatch with the actual indexing in _bidding_history #1312

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
08c5f34
Update bridge_bidding.py
Amir-Arsalan Apr 24, 2026
2d8aef5
Update bridge_bidding.py
Amir-Arsalan Apr 24, 2026
998f521
Update bridge_bidding.py
Amir-Arsalan Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions pgx/bridge_bidding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,12 +82,11 @@ class State(core.State):
# bidding_history stores the bid of each player in chronological order
# Maximum length = 319
# Each element contains an integer representing an action:
# bid: 0 ~ 34
# pass: 35
# double: 36
# redouble: 37
# pass: 0
# double: 1
# redouble: 2
# bid: 3 ~ 37 (3=1C, 4=1D, 5=1H, 6=1S, 7=1NT, ... 33=7C, 34=7D, 35=7H, 36=7S, 37=7NT)
# no action: -1
# TODO: change to pass = 0, double = 1, redouble = 2, bid = 3 ~ 37
# We can identify which player made each bid from the index of the element (ix % 4)
_bidding_history: Array = jnp.full(319, -1, dtype=jnp.int32)
# dealer: a player who starts bidding
Expand Down